mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[PR #957] [CLOSED] Support show icon when has an external monitor #1222
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#1222
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/MonitorControl/MonitorControl/pull/957
Author: @Demogorgon314
Created: 2/22/2022
Status: ❌ Closed
Base:
main← Head:impl/show-icon-when-has-external-monitor-only📝 Commits (1)
208d587Support show icon when has an external monitor📊 Changes
5 files changed (+18 additions, -3 deletions)
View changed files
📝
MonitorControl/Enums/PrefKey.swift(+2 -1)📝
MonitorControl/Info.plist(+1 -1)📝
MonitorControl/Support/MenuHandler.swift(+13 -0)📝
MonitorControl/UI/Base.lproj/Main.storyboard(+1 -0)📝
MonitorControlHelper/Info.plist(+1 -1)📄 Description
Since the new Macbook Pro 14 inches has a notch, the menu bar space is limited, I only want menu icons to show when plugging an external monitor, when I unplugged it, the icon should be hidden, so it will save menu bar space.
So I introduced a new menu Icon option: Only if has an external monitor.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.