[PR #906] [MERGED] Onboarding Screen #1212

Closed
opened 2026-05-05 07:07:55 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/906
Author: @the0neyouseek
Created: 1/22/2022
Status: Merged
Merged: 1/26/2022
Merged by: @waydabber

Base: mainHead: feat/onboarding


📝 Commits (5)

  • de80229 feat: Onboarding Screen
  • 2c69064 feat: Open Menu on "Start using MonitorControl"
  • 645dc47 i18n: Translate keyboard screenshot hint
  • 4984e01 Merge branch 'main' into feat/onboarding
  • 000beb5 bug: Fix AppDelegate

📊 Changes

37 files changed (+944 additions, -39 deletions)

View changed files

📝 MonitorControl.xcodeproj/project.pbxproj (+26 -6)
MonitorControl/Assets.xcassets/onboarding_icon_keyboard.imageset/Contents.json (+18 -0)
MonitorControl/Assets.xcassets/onboarding_icon_keyboard.imageset/icon_keyboard.png (+0 -0)
MonitorControl/Assets.xcassets/onboarding_icon_keyboard.imageset/icon_keyboard@2x.png (+0 -0)
MonitorControl/Assets.xcassets/onboarding_icon_person.imageset/Contents.json (+18 -0)
MonitorControl/Assets.xcassets/onboarding_icon_person.imageset/icon_person.png (+0 -0)
MonitorControl/Assets.xcassets/onboarding_icon_person.imageset/icon_person@2x.png (+0 -0)
MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/Contents.json (+40 -0)
MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/onboarding_keyboard.png (+0 -0)
MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/onboarding_keyboard@2x.png (+0 -0)
MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/onboarding_keyboard_dark.png (+0 -0)
MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/onboarding_keyboard_dark@2x.png (+0 -0)
📝 MonitorControl/Info.plist (+1 -1)
📝 MonitorControl/Support/AppDelegate.swift (+47 -25)
📝 MonitorControl/Support/MediaKeyTapManager.swift (+2 -2)
📝 MonitorControl/UI/Base.lproj/Main.storyboard (+254 -3)
📝 MonitorControl/UI/de.lproj/Main.strings (+42 -0)
📝 MonitorControl/UI/en.lproj/Main.strings (+42 -0)
📝 MonitorControl/UI/es.lproj/Main.strings (+42 -0)
📝 MonitorControl/UI/fr.lproj/Main.strings (+42 -0)

...and 17 more files

📄 Description

This PR is related to this issue: #676

What's new

  • Add an onboarding screen (only appear on first launch)
  • 🇫🇷 French translations for the new onboarding screen
  • 🛠 Reorganize AppDelegate a bit
  • 🛠 Move View Controllers into folders

Tests

I've tested the onboarding screen on both small and large screen, HiDPI and normal res, light and dark mode.

If you want to test the PR you can save your preferences located here:

~/Library/Preferences/me.guillaumeb.MonitorControl.plist

and run this command to reset your current preferences (where the app check to know if it was started once)

$ defaults delete me.guillaumeb.MonitorControl

before the launching the project in XCode.

What's left to do

All current translations beside French & English (for the new onboarding) are missing for now.
If you want to help with translations, please read the opening post of this discussion: #637

  • Translations :
    • Spanish
    • German
    • Hungarian
    • Italian
    • Korean
    • Dutch
    • Portuguese (Brazil)
    • Turkish
    • Chinese, Simplified
    • Chinese, Traditional (Taïwan)
  • I also forgot to translate the keyboard screenshot part (I'll get to it asap)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/906 **Author:** [@the0neyouseek](https://github.com/the0neyouseek) **Created:** 1/22/2022 **Status:** ✅ Merged **Merged:** 1/26/2022 **Merged by:** [@waydabber](https://github.com/waydabber) **Base:** `main` ← **Head:** `feat/onboarding` --- ### 📝 Commits (5) - [`de80229`](https://github.com/MonitorControl/MonitorControl/commit/de80229b5ed156379963dc258560b0a55caab438) feat: Onboarding Screen - [`2c69064`](https://github.com/MonitorControl/MonitorControl/commit/2c69064566bb27511a0e6b0a04f305c5a6deec75) feat: Open Menu on "Start using MonitorControl" - [`645dc47`](https://github.com/MonitorControl/MonitorControl/commit/645dc47a81a67762497c56096138ce8b27731c41) i18n: Translate keyboard screenshot hint - [`4984e01`](https://github.com/MonitorControl/MonitorControl/commit/4984e01e3624ee2c4cb78fd6420aa85183d75663) Merge branch 'main' into feat/onboarding - [`000beb5`](https://github.com/MonitorControl/MonitorControl/commit/000beb5ff7e9bd31812e0f1af03090689a9eeec6) bug: Fix AppDelegate ### 📊 Changes **37 files changed** (+944 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl.xcodeproj/project.pbxproj` (+26 -6) ➕ `MonitorControl/Assets.xcassets/onboarding_icon_keyboard.imageset/Contents.json` (+18 -0) ➕ `MonitorControl/Assets.xcassets/onboarding_icon_keyboard.imageset/icon_keyboard.png` (+0 -0) ➕ `MonitorControl/Assets.xcassets/onboarding_icon_keyboard.imageset/icon_keyboard@2x.png` (+0 -0) ➕ `MonitorControl/Assets.xcassets/onboarding_icon_person.imageset/Contents.json` (+18 -0) ➕ `MonitorControl/Assets.xcassets/onboarding_icon_person.imageset/icon_person.png` (+0 -0) ➕ `MonitorControl/Assets.xcassets/onboarding_icon_person.imageset/icon_person@2x.png` (+0 -0) ➕ `MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/Contents.json` (+40 -0) ➕ `MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/onboarding_keyboard.png` (+0 -0) ➕ `MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/onboarding_keyboard@2x.png` (+0 -0) ➕ `MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/onboarding_keyboard_dark.png` (+0 -0) ➕ `MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/onboarding_keyboard_dark@2x.png` (+0 -0) 📝 `MonitorControl/Info.plist` (+1 -1) 📝 `MonitorControl/Support/AppDelegate.swift` (+47 -25) 📝 `MonitorControl/Support/MediaKeyTapManager.swift` (+2 -2) 📝 `MonitorControl/UI/Base.lproj/Main.storyboard` (+254 -3) 📝 `MonitorControl/UI/de.lproj/Main.strings` (+42 -0) 📝 `MonitorControl/UI/en.lproj/Main.strings` (+42 -0) 📝 `MonitorControl/UI/es.lproj/Main.strings` (+42 -0) 📝 `MonitorControl/UI/fr.lproj/Main.strings` (+42 -0) _...and 17 more files_ </details> ### 📄 Description This PR is related to this issue: #676 ### What's new - ✨ Add an onboarding screen (only appear on first launch) - 🇫🇷 French translations for the new onboarding screen - 🛠 Reorganize AppDelegate a bit - 🛠 Move View Controllers into folders ### Tests I've tested the onboarding screen on both small and large screen, HiDPI and normal res, light and dark mode. If you want to test the PR you can save your preferences located here: ``` ~/Library/Preferences/me.guillaumeb.MonitorControl.plist ``` and run this command to reset your current preferences (where the app check to know if it was started once) ``` $ defaults delete me.guillaumeb.MonitorControl ``` before the launching the project in XCode. ### What's left to do All current translations beside French & English (for the new onboarding) are missing for now. If you want to help with translations, please read the opening post of this discussion: #637 - [ ] Translations : - [ ] Spanish - [ ] German - [ ] Hungarian - [ ] Italian - [ ] Korean - [ ] Dutch - [ ] Portuguese (Brazil) - [ ] Turkish - [ ] Chinese, Simplified - [ ] Chinese, Traditional (Taïwan) - [x] I also forgot to translate the keyboard screenshot part (I'll get to it asap) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 07:07:55 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/MonitorControl#1212
No description provided.