mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[PR #906] [MERGED] Onboarding Screen #1212
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#1212
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/MonitorControl/MonitorControl/pull/906
Author: @the0neyouseek
Created: 1/22/2022
Status: ✅ Merged
Merged: 1/26/2022
Merged by: @waydabber
Base:
main← Head:feat/onboarding📝 Commits (5)
de80229feat: Onboarding Screen2c69064feat: Open Menu on "Start using MonitorControl"645dc47i18n: Translate keyboard screenshot hint4984e01Merge branch 'main' into feat/onboarding000beb5bug: Fix AppDelegate📊 Changes
37 files changed (+944 additions, -39 deletions)
View changed files
📝
MonitorControl.xcodeproj/project.pbxproj(+26 -6)➕
MonitorControl/Assets.xcassets/onboarding_icon_keyboard.imageset/Contents.json(+18 -0)➕
MonitorControl/Assets.xcassets/onboarding_icon_keyboard.imageset/icon_keyboard.png(+0 -0)➕
MonitorControl/Assets.xcassets/onboarding_icon_keyboard.imageset/icon_keyboard@2x.png(+0 -0)➕
MonitorControl/Assets.xcassets/onboarding_icon_person.imageset/Contents.json(+18 -0)➕
MonitorControl/Assets.xcassets/onboarding_icon_person.imageset/icon_person.png(+0 -0)➕
MonitorControl/Assets.xcassets/onboarding_icon_person.imageset/icon_person@2x.png(+0 -0)➕
MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/Contents.json(+40 -0)➕
MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/onboarding_keyboard.png(+0 -0)➕
MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/onboarding_keyboard@2x.png(+0 -0)➕
MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/onboarding_keyboard_dark.png(+0 -0)➕
MonitorControl/Assets.xcassets/onboarding_keyboard.imageset/onboarding_keyboard_dark@2x.png(+0 -0)📝
MonitorControl/Info.plist(+1 -1)📝
MonitorControl/Support/AppDelegate.swift(+47 -25)📝
MonitorControl/Support/MediaKeyTapManager.swift(+2 -2)📝
MonitorControl/UI/Base.lproj/Main.storyboard(+254 -3)📝
MonitorControl/UI/de.lproj/Main.strings(+42 -0)📝
MonitorControl/UI/en.lproj/Main.strings(+42 -0)📝
MonitorControl/UI/es.lproj/Main.strings(+42 -0)📝
MonitorControl/UI/fr.lproj/Main.strings(+42 -0)...and 17 more files
📄 Description
This PR is related to this issue: #676
What's new
Tests
I've tested the onboarding screen on both small and large screen, HiDPI and normal res, light and dark mode.
If you want to test the PR you can save your preferences located here:
and run this command to reset your current preferences (where the app check to know if it was started once)
before the launching the project in XCode.
What's left to do
All current translations beside French & English (for the new onboarding) are missing for now.
If you want to help with translations, please read the opening post of this discussion: #637
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.