[PR #786] [MERGED] Some minor fixes and improvements #1204

New issue

Closed

opened 2026-05-05 07:07:35 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:07:35 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/786
Author: @waydabber
Created: 11/12/2021
Status: ✅ Merged
Merged: 11/14/2021
Merged by: @waydabber

Base: master ← Head: fixes

📝 Commits (5)

abc5ee7 Fixed wrong button placement
c2b88b4 Decreasing wait time after sleep + allowing internal brightness control meanwhile by disengaging the brightness keys on sleep
71cafeb Disengage brightness keys upon reconfiguration request as well.
665ed5a Fix signing
8cf479b Bumped compiler swift version to 5.5

📊 Changes

17 files changed (+264 additions, -252 deletions)

View changed files

📝 .swift-version (+1 -1)
📝 MonitorControl.xcodeproj/project.pbxproj (+45 -9)
📝 MonitorControl/Extensions/CGDirectDisplayID+Extension.swift (+3 -3)
📝 MonitorControl/Extensions/NSScreen+Extension.swift (+1 -1)
📝 MonitorControl/Info.plist (+1 -1)
📝 MonitorControl/Model/Display.swift (+9 -9)
📝 MonitorControl/Model/OtherDisplay.swift (+5 -5)
📝 MonitorControl/Support/AppDelegate.swift (+6 -3)
📝 MonitorControl/Support/DisplayManager.swift (+6 -6)
📝 MonitorControl/Support/MediaKeyTapManager.swift (+7 -3)
📝 MonitorControl/Support/OSDUtils.swift (+3 -3)
📝 MonitorControl/Support/SliderHandler.swift (+1 -1)
📝 MonitorControl/Support/UpdaterDelegate.swift (+1 -1)
📝 MonitorControl/UI/Base.lproj/Main.storyboard (+25 -25)
📝 MonitorControl/UI/es.lproj/Main.strings (+148 -179)
📝 MonitorControl/View Controllers/DisplaysPrefsViewController.swift (+1 -1)
📝 MonitorControlHelper/Info.plist (+1 -1)

📄 Description

Fixed wrong quit button placement when menu is hidden
Reduced sleep and reconfiguration wait times by half (this might adversely effect older displays when DDC read is enabled - but it is disabled by default now)
Disengaged brightness keys after sleep and reconfiguration so it does not interfere with using the brightness keys in the sobering period on M1 macbooks (they wake up superfast)
Modified Swift version number to 5.5 (this had some minor effect on the code - like removal of unneeded return keywords - but will become handy as I can simplify the syntax of some of the asynchronous stuff later)
Bumped app version number to 4.0.2

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/786 **Author:** [@waydabber](https://github.com/waydabber) **Created:** 11/12/2021 **Status:** ✅ Merged **Merged:** 11/14/2021 **Merged by:** [@waydabber](https://github.com/waydabber) **Base:** `master` ← **Head:** `fixes` --- ### 📝 Commits (5) - [`abc5ee7`](https://github.com/MonitorControl/MonitorControl/commit/abc5ee75732e624fe628ab2ed1a7aca2c8eff57a) Fixed wrong button placement - [`c2b88b4`](https://github.com/MonitorControl/MonitorControl/commit/c2b88b43a1a313ec09d8d71b08ce12eef38d0cc4) Decreasing wait time after sleep + allowing internal brightness control meanwhile by disengaging the brightness keys on sleep - [`71cafeb`](https://github.com/MonitorControl/MonitorControl/commit/71cafeb995d736d325a31dd5216727058413ed93) Disengage brightness keys upon reconfiguration request as well. - [`665ed5a`](https://github.com/MonitorControl/MonitorControl/commit/665ed5af94132de375de633b75af89d69a9cd70d) Fix signing - [`8cf479b`](https://github.com/MonitorControl/MonitorControl/commit/8cf479bf318c71bd80588b84da2644d03c318807) Bumped compiler swift version to 5.5 ### 📊 Changes **17 files changed** (+264 additions, -252 deletions) <details> <summary>View changed files</summary> 📝 `.swift-version` (+1 -1) 📝 `MonitorControl.xcodeproj/project.pbxproj` (+45 -9) 📝 `MonitorControl/Extensions/CGDirectDisplayID+Extension.swift` (+3 -3) 📝 `MonitorControl/Extensions/NSScreen+Extension.swift` (+1 -1) 📝 `MonitorControl/Info.plist` (+1 -1) 📝 `MonitorControl/Model/Display.swift` (+9 -9) 📝 `MonitorControl/Model/OtherDisplay.swift` (+5 -5) 📝 `MonitorControl/Support/AppDelegate.swift` (+6 -3) 📝 `MonitorControl/Support/DisplayManager.swift` (+6 -6) 📝 `MonitorControl/Support/MediaKeyTapManager.swift` (+7 -3) 📝 `MonitorControl/Support/OSDUtils.swift` (+3 -3) 📝 `MonitorControl/Support/SliderHandler.swift` (+1 -1) 📝 `MonitorControl/Support/UpdaterDelegate.swift` (+1 -1) 📝 `MonitorControl/UI/Base.lproj/Main.storyboard` (+25 -25) 📝 `MonitorControl/UI/es.lproj/Main.strings` (+148 -179) 📝 `MonitorControl/View Controllers/DisplaysPrefsViewController.swift` (+1 -1) 📝 `MonitorControlHelper/Info.plist` (+1 -1) </details> ### 📄 Description - Fixed wrong quit button placement when menu is hidden - Reduced sleep and reconfiguration wait times by half (this might adversely effect older displays when DDC read is enabled - but it is disabled by default now) - Disengaged brightness keys after sleep and reconfiguration so it does not interfere with using the brightness keys in the sobering period on M1 macbooks (they wake up superfast) - Modified Swift version number to 5.5 (this had some minor effect on the code - like removal of unneeded `return` keywords - but will become handy as I can simplify the syntax of some of the asynchronous stuff later) - Bumped app version number to 4.0.2 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>