[PR #738] [MERGED] Some additional fixes #1196

New issue

Closed

opened 2026-05-05 07:07:24 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:07:24 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/738
Author: @waydabber
Created: 10/24/2021
Status: ✅ Merged
Merged: 10/25/2021
Merged by: @waydabber

Base: master ← Head: experimental

📝 Commits (7)

85ea68f Fix naming of wakeNotification()
060fa79 Fix for failing to update Advanced Settings checkbox on Preferences Reset
4f6aa01 Better handling of dummy displays.
6fd89de Reverted skipping menu for dummy displays.
3cf9eba Fix semaphore issue.
a5664e9 Dummy displays are marked with No Control under Preferences/Displays
7fe745e Removed unused property from getAffectedDisplays()

📊 Changes

10 files changed (+70 additions, -26 deletions)

View changed files

📝 MonitorControl/Info.plist (+1 -1)
📝 MonitorControl/Model/AppleDisplay.swift (+14 -2)
📝 MonitorControl/Model/Display.swift (+22 -6)
📝 MonitorControl/Model/OtherDisplay.swift (+3 -3)
📝 MonitorControl/Support/AppDelegate.swift (+3 -3)
📝 MonitorControl/Support/Arm64DDC.swift (+4 -0)
📝 MonitorControl/Support/DisplayManager.swift (+12 -5)
📝 MonitorControl/View Controllers/DisplaysPrefsViewController.swift (+9 -5)
📝 MonitorControl/View Controllers/MainPrefsViewController.swift (+1 -0)
📝 MonitorControlHelper/Info.plist (+1 -1)

📄 Description

Some additional fixes for issues that came up during testing:

Fix naming of wakeNotification()
Fix for failing to update Advanced Settings checkbox on Preferences Reset.
Better handling of known dummy displays.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/738 **Author:** [@waydabber](https://github.com/waydabber) **Created:** 10/24/2021 **Status:** ✅ Merged **Merged:** 10/25/2021 **Merged by:** [@waydabber](https://github.com/waydabber) **Base:** `master` ← **Head:** `experimental` --- ### 📝 Commits (7) - [`85ea68f`](https://github.com/MonitorControl/MonitorControl/commit/85ea68f246cc6f5aa49893a16360a4bb0d52a535) Fix naming of wakeNotification() - [`060fa79`](https://github.com/MonitorControl/MonitorControl/commit/060fa79ddabe6090965ab1eb8bfca384e67fcf85) Fix for failing to update Advanced Settings checkbox on Preferences Reset - [`4f6aa01`](https://github.com/MonitorControl/MonitorControl/commit/4f6aa01ffc09374f66d6211e0fbe88dcdce56091) Better handling of dummy displays. - [`6fd89de`](https://github.com/MonitorControl/MonitorControl/commit/6fd89de9ab16a4ee6f05392fc40160675eaca454) Reverted skipping menu for dummy displays. - [`3cf9eba`](https://github.com/MonitorControl/MonitorControl/commit/3cf9eba4a2203ed3d9c7ac03f24e837f4cbfae19) Fix semaphore issue. - [`a5664e9`](https://github.com/MonitorControl/MonitorControl/commit/a5664e930cdd0747ba899a11e75b4b885602076f) Dummy displays are marked with No Control under Preferences/Displays - [`7fe745e`](https://github.com/MonitorControl/MonitorControl/commit/7fe745e26d6e7012d5c369dfcc9d23f4a26d4191) Removed unused property from getAffectedDisplays() ### 📊 Changes **10 files changed** (+70 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl/Info.plist` (+1 -1) 📝 `MonitorControl/Model/AppleDisplay.swift` (+14 -2) 📝 `MonitorControl/Model/Display.swift` (+22 -6) 📝 `MonitorControl/Model/OtherDisplay.swift` (+3 -3) 📝 `MonitorControl/Support/AppDelegate.swift` (+3 -3) 📝 `MonitorControl/Support/Arm64DDC.swift` (+4 -0) 📝 `MonitorControl/Support/DisplayManager.swift` (+12 -5) 📝 `MonitorControl/View Controllers/DisplaysPrefsViewController.swift` (+9 -5) 📝 `MonitorControl/View Controllers/MainPrefsViewController.swift` (+1 -0) 📝 `MonitorControlHelper/Info.plist` (+1 -1) </details> ### 📄 Description Some additional fixes for issues that came up during testing: - Fix naming of wakeNotification() - Fix for failing to update Advanced Settings checkbox on Preferences Reset. - Better handling of known dummy displays. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>