[PR #714] [MERGED] Updated how 'Show advanced settings' works #1188

New issue

Closed

opened 2026-05-05 07:07:05 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:07:05 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/714
Author: @waydabber
Created: 10/14/2021
Status: ✅ Merged
Merged: 10/15/2021
Merged by: @waydabber

Base: master ← Head: experimental

📝 Commits (8)

de52b87 Reorganized Preferences a bit - moved Show advanced to Displays tab with local scope only.
6077671 Removed an unneeded text row from Preferences for cleaner look
aafc3e9 Fix layout issue
835064b Update README.md
b6039cb Updated screenshots
7c13736 Added some info about supported hardware
b7c5f05 Update README.md
0b3ea20 Update README.md

📊 Changes

33 files changed (+273 additions, -654 deletions)

View changed files

📝 .github/pref_1.png (+0 -0)
📝 .github/pref_2.png (+0 -0)
📝 .github/pref_3.png (+0 -0)
📝 .github/pref_4.png (+0 -0)
📝 .github/screenshot.png (+0 -0)
📝 MonitorControl/Enums/PrefKey.swift (+0 -3)
📝 MonitorControl/Info.plist (+1 -1)
📝 MonitorControl/Model/Display.swift (+1 -1)
📝 MonitorControl/Model/OtherDisplay.swift (+1 -3)
📝 MonitorControl/Support/AppDelegate.swift (+2 -2)
📝 MonitorControl/Support/MenuHandler.swift (+1 -5)
📝 MonitorControl/UI/Base.lproj/Main.storyboard (+106 -160)
📝 MonitorControl/UI/de.lproj/Main.strings (+7 -19)
📝 MonitorControl/UI/en.lproj/Main.strings (+6 -18)
📝 MonitorControl/UI/es-419.lproj/Main.strings (+6 -18)
📝 MonitorControl/UI/fr.lproj/Main.strings (+6 -18)
📝 MonitorControl/UI/hu.lproj/Main.strings (+6 -18)
📝 MonitorControl/UI/it.lproj/Main.strings (+6 -18)
📝 MonitorControl/UI/ja.lproj/Main.strings (+6 -18)
📝 MonitorControl/UI/ko.lproj/Main.strings (+6 -18)

...and 13 more files

📄 Description

This PR has the following changes:

Moved Show advanced settings to the Displays tab with a local scope only.
Now all other panes will show all settings by default.
Reorganized the General to be more logical.
Removed unnecessary 'Disable software fallback' option.

This is how the Displays tab now looks like with advanced settings enabled (see the setting in the bottom right corner) and using light theme:

This is how the tab looks like with advanced disabled with dark theme:

Note: I was extra careful not to introduce any changes that mess up localizatons as we would not want an other round of translations before the full release.

Let me know if you don't like it, I am open to suggestions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/714 **Author:** [@waydabber](https://github.com/waydabber) **Created:** 10/14/2021 **Status:** ✅ Merged **Merged:** 10/15/2021 **Merged by:** [@waydabber](https://github.com/waydabber) **Base:** `master` ← **Head:** `experimental` --- ### 📝 Commits (8) - [`de52b87`](https://github.com/MonitorControl/MonitorControl/commit/de52b879cf93bb0c65b8c9b05bbbb6f0df260de6) Reorganized Preferences a bit - moved Show advanced to Displays tab with local scope only. - [`6077671`](https://github.com/MonitorControl/MonitorControl/commit/6077671cda103153cd82a5f49a361ab234ab15d8) Removed an unneeded text row from Preferences for cleaner look - [`aafc3e9`](https://github.com/MonitorControl/MonitorControl/commit/aafc3e90d371b46a3027b7ab8b2490246e48a600) Fix layout issue - [`835064b`](https://github.com/MonitorControl/MonitorControl/commit/835064b18bd04b9b82b41fe6d027e2ed23cd9f2d) Update README.md - [`b6039cb`](https://github.com/MonitorControl/MonitorControl/commit/b6039cb8854503325361124526dc3a78d231eab3) Updated screenshots - [`7c13736`](https://github.com/MonitorControl/MonitorControl/commit/7c137367b1ef3c0e154eaba29b2a3e548e3d5c8f) Added some info about supported hardware - [`b7c5f05`](https://github.com/MonitorControl/MonitorControl/commit/b7c5f051064133b3948a8ae9b1969f0a29f042be) Update README.md - [`0b3ea20`](https://github.com/MonitorControl/MonitorControl/commit/0b3ea202b8a4e5b5b4abcd94283e23d0578a4e7f) Update README.md ### 📊 Changes **33 files changed** (+273 additions, -654 deletions) <details> <summary>View changed files</summary> 📝 `.github/pref_1.png` (+0 -0) 📝 `.github/pref_2.png` (+0 -0) 📝 `.github/pref_3.png` (+0 -0) 📝 `.github/pref_4.png` (+0 -0) 📝 `.github/screenshot.png` (+0 -0) 📝 `MonitorControl/Enums/PrefKey.swift` (+0 -3) 📝 `MonitorControl/Info.plist` (+1 -1) 📝 `MonitorControl/Model/Display.swift` (+1 -1) 📝 `MonitorControl/Model/OtherDisplay.swift` (+1 -3) 📝 `MonitorControl/Support/AppDelegate.swift` (+2 -2) 📝 `MonitorControl/Support/MenuHandler.swift` (+1 -5) 📝 `MonitorControl/UI/Base.lproj/Main.storyboard` (+106 -160) 📝 `MonitorControl/UI/de.lproj/Main.strings` (+7 -19) 📝 `MonitorControl/UI/en.lproj/Main.strings` (+6 -18) 📝 `MonitorControl/UI/es-419.lproj/Main.strings` (+6 -18) 📝 `MonitorControl/UI/fr.lproj/Main.strings` (+6 -18) 📝 `MonitorControl/UI/hu.lproj/Main.strings` (+6 -18) 📝 `MonitorControl/UI/it.lproj/Main.strings` (+6 -18) 📝 `MonitorControl/UI/ja.lproj/Main.strings` (+6 -18) 📝 `MonitorControl/UI/ko.lproj/Main.strings` (+6 -18) _...and 13 more files_ </details> ### 📄 Description This PR has the following changes: - Moved `Show advanced settings` to the Displays tab with a local scope only. - Now all other panes will show all settings by default. - Reorganized the General to be more logical. - Removed unnecessary 'Disable software fallback' option. This is how the Displays tab now looks like with advanced settings enabled (see the setting in the bottom right corner) and using light theme: <img width="842" alt="Screen Shot 2021-10-14 at 21 01 45" src="https://user-images.githubusercontent.com/37590873/137380529-e5205c36-c705-499c-8b64-0c808d34c898.png"> This is how the tab looks like with advanced disabled with dark theme: <img width="842" alt="Screen Shot 2021-10-14 at 21 08 39" src="https://user-images.githubusercontent.com/37590873/137380514-55fd5fc4-825c-4219-b5a5-230e786c0843.png"> Note: I was extra careful not to introduce any changes that mess up localizatons as we would not want an other round of translations before the full release. Let me know if you don't like it, I am open to suggestions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>