[PR #671] [MERGED] Fixing software dimming issues #1165

New issue

Closed

opened 2026-05-05 07:06:35 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:06:35 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/671
Author: @waydabber
Created: 10/4/2021
Status: ✅ Merged
Merged: 10/5/2021
Merged by: @waydabber

Base: master ← Head: fix/betaissues

📝 Commits (9)

65503d9 Change icon order
b3c22e5 Added option for minimum brightness, fixed text for external display brightness control (+ updated all translations)
10521b8 Fix cumulative darkening issue upon toggling Disable dimming as fallback when software brightness is not 100%
6ed09c9 Further improvement.
4083388 New 'Avoid gammatable manipulation' option for coexistence with f.lux in software mode.
aa1294f Merge branch 'master' into fix/betaissues
a29008e Fix some translation errors
d081933 Fix signing
04e0a9e Make sure that key repeat speed for custom shortcuts do not go below a certain threshold.

📊 Changes

40 files changed (+406 additions, -118 deletions)

View changed files

📝 MonitorControl/Enums/PrefKey.swift (+6 -0)
📝 MonitorControl/Info.plist (+1 -1)
📝 MonitorControl/Model/Display.swift (+7 -6)
📝 MonitorControl/Model/OtherDisplay.swift (+7 -2)
📝 MonitorControl/Support/KeyboardShortcutsManager.swift (+2 -2)
📝 MonitorControl/UI/Base.lproj/Main.storyboard (+85 -44)
📝 MonitorControl/UI/de.lproj/Localizable.strings (+4 -1)
📝 MonitorControl/UI/de.lproj/Main.strings (+11 -2)
📝 MonitorControl/UI/en.lproj/Localizable.strings (+4 -1)
📝 MonitorControl/UI/en.lproj/Main.strings (+11 -2)
📝 MonitorControl/UI/es-419.lproj/Localizable.strings (+4 -1)
📝 MonitorControl/UI/es-419.lproj/Main.strings (+11 -2)
📝 MonitorControl/UI/fr.lproj/Localizable.strings (+4 -1)
📝 MonitorControl/UI/fr.lproj/Main.strings (+11 -2)
📝 MonitorControl/UI/hu.lproj/Localizable.strings (+4 -1)
📝 MonitorControl/UI/hu.lproj/Main.strings (+11 -2)
📝 MonitorControl/UI/it.lproj/Localizable.strings (+4 -1)
📝 MonitorControl/UI/it.lproj/Main.strings (+11 -2)
📝 MonitorControl/UI/ja.lproj/Localizable.strings (+4 -1)
📝 MonitorControl/UI/ja.lproj/Main.strings (+11 -2)

...and 20 more files

📄 Description

Changed default to a minimum software dimming of 15% for safety reasons.
Added advanced option to enable zero brightness with software dimming.
Fixed text for external display brightness control keyboard shortcut (+ updated all translations).
Fix cumulative darkening bug upon toggling 'Disable dimming as fallback'.
Added 'Avoid gamma table manipulation' option for coexistence with f.lux.
Make sure that key repeat speed for custom shortcuts do not go below a certain threshold.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/671 **Author:** [@waydabber](https://github.com/waydabber) **Created:** 10/4/2021 **Status:** ✅ Merged **Merged:** 10/5/2021 **Merged by:** [@waydabber](https://github.com/waydabber) **Base:** `master` ← **Head:** `fix/betaissues` --- ### 📝 Commits (9) - [`65503d9`](https://github.com/MonitorControl/MonitorControl/commit/65503d92f47b900270a8f18e5bdb2428b4b5d9f9) Change icon order - [`b3c22e5`](https://github.com/MonitorControl/MonitorControl/commit/b3c22e56c58cab95de9e3271a4c45561aea5c2df) Added option for minimum brightness, fixed text for external display brightness control (+ updated all translations) - [`10521b8`](https://github.com/MonitorControl/MonitorControl/commit/10521b840fc7fd84e9ad97b47d610a97c1e44aae) Fix cumulative darkening issue upon toggling Disable dimming as fallback when software brightness is not 100% - [`6ed09c9`](https://github.com/MonitorControl/MonitorControl/commit/6ed09c9fe85f1fced203acd95c3266a63005ecf7) Further improvement. - [`4083388`](https://github.com/MonitorControl/MonitorControl/commit/4083388f638679d756db96c03d52b4c2febf1612) New 'Avoid gammatable manipulation' option for coexistence with f.lux in software mode. - [`aa1294f`](https://github.com/MonitorControl/MonitorControl/commit/aa1294f3a5cd1a1c2c3382fe09f8696df38fbeda) Merge branch 'master' into fix/betaissues - [`a29008e`](https://github.com/MonitorControl/MonitorControl/commit/a29008e9961d75b0e117f2689235078effaa2693) Fix some translation errors - [`d081933`](https://github.com/MonitorControl/MonitorControl/commit/d08193385ada8622daf9fb367ff033a08ea51b68) Fix signing - [`04e0a9e`](https://github.com/MonitorControl/MonitorControl/commit/04e0a9e05f524dff26346c663c2e4e0254e7d3a8) Make sure that key repeat speed for custom shortcuts do not go below a certain threshold. ### 📊 Changes **40 files changed** (+406 additions, -118 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl/Enums/PrefKey.swift` (+6 -0) 📝 `MonitorControl/Info.plist` (+1 -1) 📝 `MonitorControl/Model/Display.swift` (+7 -6) 📝 `MonitorControl/Model/OtherDisplay.swift` (+7 -2) 📝 `MonitorControl/Support/KeyboardShortcutsManager.swift` (+2 -2) 📝 `MonitorControl/UI/Base.lproj/Main.storyboard` (+85 -44) 📝 `MonitorControl/UI/de.lproj/Localizable.strings` (+4 -1) 📝 `MonitorControl/UI/de.lproj/Main.strings` (+11 -2) 📝 `MonitorControl/UI/en.lproj/Localizable.strings` (+4 -1) 📝 `MonitorControl/UI/en.lproj/Main.strings` (+11 -2) 📝 `MonitorControl/UI/es-419.lproj/Localizable.strings` (+4 -1) 📝 `MonitorControl/UI/es-419.lproj/Main.strings` (+11 -2) 📝 `MonitorControl/UI/fr.lproj/Localizable.strings` (+4 -1) 📝 `MonitorControl/UI/fr.lproj/Main.strings` (+11 -2) 📝 `MonitorControl/UI/hu.lproj/Localizable.strings` (+4 -1) 📝 `MonitorControl/UI/hu.lproj/Main.strings` (+11 -2) 📝 `MonitorControl/UI/it.lproj/Localizable.strings` (+4 -1) 📝 `MonitorControl/UI/it.lproj/Main.strings` (+11 -2) 📝 `MonitorControl/UI/ja.lproj/Localizable.strings` (+4 -1) 📝 `MonitorControl/UI/ja.lproj/Main.strings` (+11 -2) _...and 20 more files_ </details> ### 📄 Description - Changed default to a minimum software dimming of 15% for safety reasons. - Added advanced option to enable zero brightness with software dimming. - Fixed text for external display brightness control keyboard shortcut (+ updated all translations). - Fix cumulative darkening bug upon toggling 'Disable dimming as fallback'. - Added 'Avoid gamma table manipulation' option for coexistence with f.lux. - Make sure that key repeat speed for custom shortcuts do not go below a certain threshold. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>