[PR #645] [MERGED] feat: close preference pane using cmd + w #1146

New issue

Closed

opened 2026-05-05 07:06:02 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:06:02 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/645
Author: @JoniVR
Created: 10/1/2021
Status: ✅ Merged
Merged: 10/1/2021
Merged by: @JoniVR

Base: master ← Head: feat/close-using-shortcut

📝 Commits (1)

60257ed feat: close preference pane using cmd+w

📊 Changes

3 files changed (+14 additions, -2 deletions)

View changed files

📝 MonitorControl/Extensions/Preferences+Extension.swift (+12 -0)
📝 MonitorControl/Info.plist (+1 -1)
📝 MonitorControlHelper/Info.plist (+1 -1)

📄 Description

closes #639

This implements the ability to close the preferences pane using command + w

I looked around at which shortcuts other applications with similar Preference system listened to (Vimac and system prefs for example) and decided that command + w made most sense. Feel free to correct me or suggest other combinations.

I didn't manage to get esc to work, that usually requires implementing cancelOperation, perhaps the window doesn't have proper focus or something else is wrong. Though I didn't notice any other apps listening to escape either so maybe we shouldn't do it as to not deviate from "the standard".

Another thing to note: If you were to assign command + w to a MonitorControl shortcut, that would take priority, which makes sense imo.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/645 **Author:** [@JoniVR](https://github.com/JoniVR) **Created:** 10/1/2021 **Status:** ✅ Merged **Merged:** 10/1/2021 **Merged by:** [@JoniVR](https://github.com/JoniVR) **Base:** `master` ← **Head:** `feat/close-using-shortcut` --- ### 📝 Commits (1) - [`60257ed`](https://github.com/MonitorControl/MonitorControl/commit/60257edadf14012427ad505778e418359b912b13) feat: close preference pane using cmd+w ### 📊 Changes **3 files changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl/Extensions/Preferences+Extension.swift` (+12 -0) 📝 `MonitorControl/Info.plist` (+1 -1) 📝 `MonitorControlHelper/Info.plist` (+1 -1) </details> ### 📄 Description closes #639 This implements the ability to close the preferences pane using <kbd>command</kbd> + <kbd>w</kbd> I looked around at which shortcuts other applications with similar Preference system listened to (Vimac and system prefs for example) and decided that <kbd>command</kbd> + <kbd>w</kbd> made most sense. Feel free to correct me or suggest other combinations. I didn't manage to get <kbd>esc</kbd> to work, that usually requires implementing `cancelOperation`, perhaps the window doesn't have proper focus or something else is wrong. Though I didn't notice any other apps listening to escape either so maybe we shouldn't do it as to not deviate from "the standard". Another thing to note: If you were to assign <kbd>command</kbd> + <kbd>w</kbd> to a MonitorControl shortcut, that would take priority, which makes sense imo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>