mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[PR #276] [MERGED] Show audio muted OSD image when audio volume value is 0 #1080
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#1080
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/MonitorControl/MonitorControl/pull/276
Author: @robertbressi
Created: 8/12/2020
Status: ✅ Merged
Merged: 10/18/2020
Merged by: @JoniVR
Base:
master← Head:robertbressi/osd-mute-icon📝 Commits (2)
01655b2Show audio muted OSD image when audio volume value is 0e67fd19Minor code duplication cleanup📊 Changes
1 file changed (+26 additions, -22 deletions)
View changed files
📝
MonitorControl/Model/Display.swift(+26 -22)📄 Description
Currently, if you reduce the volume to zero, the OSD image is still the non-muted audio speaker, even though the volume is muted.
This change will set the OSD image to the muted audio speaker if the volume becomes zero.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.