mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[GH-ISSUE #148] Ctrl + F1/F2 should change the internal monitor's brightness #108
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#108
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tjarksaul on GitHub (Nov 6, 2019).
Original GitHub issue: https://github.com/MonitorControl/MonitorControl/issues/148
This is the default behaviour on Apple monitors.
@jhildenbiddle commented on GitHub (Nov 13, 2019):
I'd also like some way to control brightness of the internal display when using MonitorControl with an external monitor.
@yedlosh commented on GitHub (Nov 29, 2019):
Right now I am using this one instead of MonitorControl to achieve that:
https://github.com/Bensge/NativeDisplayBrightness
It has no UI, it's not supported anymore, but it simply controls brightness of all my external monitors at once using F1/F2. Which is actually everything I needed.
So Fn keys remain free to control internal display, and F1/F2 (for me actually Fn+F1/F2) control the external ones.. and it just works 👍
@JoniVR commented on GitHub (Jan 22, 2020):
This is something that I plan on adding together with #118 but it requires a lot of rewriting under the hood.. and I'm very limited in time. I made some of the first steps in previous commit linked here (
46d7cb6) rewriting the display managing logic.The project was long overdue for some refactoring of the display logic anyways..
@JoniVR commented on GitHub (Feb 1, 2020):
Most of the code refactor is done, the internal display respects the
isEnabledoption inside settings and should also work with ctrl modifier (in that case no other displays will be controlled).Just waiting for https://github.com/the0neyouseek/MediaKeyTap/pull/5 to be reviewed/merged right now. After that I'll do a few more final things and open a PR for review.
@the0neyouseek commented on GitHub (Feb 1, 2020):
@JoniVR Merged 😉
Thanks for all your hard work on this
@JoniVR commented on GitHub (Feb 1, 2020):
Pull Request has been submitted!
For the people that know how to, please feel free to test/review it and report any issues since a lot of the display logic has changed, there's always a bigger chance of introducing new issues. It's pretty hard to test with only one configuration so the more people that test it the better.