[PR #237] [MERGED] Fix mediakeys not working everywhere, Add "none" keys option #1070

New issue

Closed

opened 2026-05-05 07:03:56 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:03:56 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/237
Author: @JoniVR
Created: 6/10/2020
Status: ✅ Merged
Merged: 6/21/2020
Merged by: @JoniVR

Base: master ← Head: fix/hotkeys-internal-fullscreen

📝 Commits (4)

4f591b2 Fix mediakeys not working on internal display or fullscreen application (#30, #176)
ec50ddd Add option to not listen for any keys
d997c87 Update Main.strings
b326b32 Add check to not ask for shortcut permissions when shortcuts are disabled (#235)

📊 Changes

6 files changed (+77 additions, -57 deletions)

View changed files

📝 MonitorControl/AppDelegate.swift (+14 -6)
📝 MonitorControl/Info.plist (+1 -1)
📝 MonitorControl/Support/Utils.swift (+11 -5)
📝 MonitorControl/UI/Base.lproj/Main.storyboard (+47 -44)
📝 MonitorControl/UI/en.lproj/Main.strings (+3 -0)
📝 MonitorControlHelper/Info.plist (+1 -1)

📄 Description

fixes #30
fixes #217
closes #176
closes #235
closes #181

Changes

Allows the user to use MonitorControl regardless of which display or window is currently focussed.
Allows the user to select "none" option in keys preferences. This disables shortcuts completely and will not prompt the user for permissions on app start.

Would be nice if someone could test this for unintended side effects.

Note

I'm having an issue with MonitorControl not supplying DDC commands correctly on Xcode tools versions above 11.3.1, so you might want to test using 11.3.1 if it's not working as expected. Opened an issue about it here: #238

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/237 **Author:** [@JoniVR](https://github.com/JoniVR) **Created:** 6/10/2020 **Status:** ✅ Merged **Merged:** 6/21/2020 **Merged by:** [@JoniVR](https://github.com/JoniVR) **Base:** `master` ← **Head:** `fix/hotkeys-internal-fullscreen` --- ### 📝 Commits (4) - [`4f591b2`](https://github.com/MonitorControl/MonitorControl/commit/4f591b239ed5747b45c134896a65718632b9ae33) Fix mediakeys not working on internal display or fullscreen application (#30, #176) - [`ec50ddd`](https://github.com/MonitorControl/MonitorControl/commit/ec50dddb767177de028f2a661b941e7e19b8942b) Add option to not listen for any keys - [`d997c87`](https://github.com/MonitorControl/MonitorControl/commit/d997c870c597f600863d1616fa1fce3981d449e6) Update Main.strings - [`b326b32`](https://github.com/MonitorControl/MonitorControl/commit/b326b325286a813a49ceb0bb512d7d3a3058f1ff) Add check to not ask for shortcut permissions when shortcuts are disabled (#235) ### 📊 Changes **6 files changed** (+77 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl/AppDelegate.swift` (+14 -6) 📝 `MonitorControl/Info.plist` (+1 -1) 📝 `MonitorControl/Support/Utils.swift` (+11 -5) 📝 `MonitorControl/UI/Base.lproj/Main.storyboard` (+47 -44) 📝 `MonitorControl/UI/en.lproj/Main.strings` (+3 -0) 📝 `MonitorControlHelper/Info.plist` (+1 -1) </details> ### 📄 Description fixes #30 fixes #217 closes #176 closes #235 closes #181 # Changes * Allows the user to use MonitorControl regardless of which display or window is currently focussed. * Allows the user to select "none" option in keys preferences. This disables shortcuts completely and will not prompt the user for permissions on app start. Would be nice if someone could test this for unintended side effects. # Note I'm having an issue with MonitorControl not supplying DDC commands correctly on Xcode tools versions above 11.3.1, so you might want to test using 11.3.1 if it's not working as expected. Opened an issue about it here: #238 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>