[PR #183] [CLOSED] If there isn't at least one enabled DDC external display, then don't tap any keys #1067

Closed
opened 2026-05-05 07:03:50 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/183
Author: @opbarnes
Created: 3/4/2020
Status: Closed

Base: masterHead: master


📝 Commits (3)

  • 0612a09 If there isn't at least one enabled DDC external display, then don't tap any keys. The use case for this is when a user wants to use MonitorControl for a monitor that resides in one location (e.g. their home), but does not want to use MonitorControl in another location (e.g. their workplace). But they also don't want to manually run or quit MonitorControl when they move locations.
  • b948865 Removed errant semicolon
  • e63473d Fixed a bug where checking if there is a need for a media key tap on CGDisplayRegisterReconfigurationCallback (there would be a need if one of the displays after the display reconfiguration is a enabled DDC external display)

📊 Changes

2 files changed (+28 additions, -7 deletions)

View changed files

📝 MonitorControl/AppDelegate.swift (+27 -7)
📝 MonitorControl/UI/Cells/ButtonCellView.swift (+1 -0)

📄 Description

If there isn't at least one enabled DDC external display, then don't tap any keys. The use case for this is when a user wants to use MonitorControl for a monitor that resides in one location (e.g. their home), but does not want to use MonitorControl in another location (e.g. their workplace). But they also don't want to manually run or quit MonitorControl when they move locations.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/183 **Author:** [@opbarnes](https://github.com/opbarnes) **Created:** 3/4/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`0612a09`](https://github.com/MonitorControl/MonitorControl/commit/0612a098e214be0e4056bdd79f4faa8b3897c677) If there isn't at least one enabled DDC external display, then don't tap any keys. The use case for this is when a user wants to use MonitorControl for a monitor that resides in one location (e.g. their home), but does not want to use MonitorControl in another location (e.g. their workplace). But they also don't want to manually run or quit MonitorControl when they move locations. - [`b948865`](https://github.com/MonitorControl/MonitorControl/commit/b948865964eea3233a0e9475db0895ae2d2c1de0) Removed errant semicolon - [`e63473d`](https://github.com/MonitorControl/MonitorControl/commit/e63473ddca5c2a133f3dbca386bf01e90ecc6962) Fixed a bug where checking if there is a need for a media key tap on CGDisplayRegisterReconfigurationCallback (there would be a need if one of the displays after the display reconfiguration is a enabled DDC external display) ### 📊 Changes **2 files changed** (+28 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl/AppDelegate.swift` (+27 -7) 📝 `MonitorControl/UI/Cells/ButtonCellView.swift` (+1 -0) </details> ### 📄 Description If there isn't at least one enabled DDC external display, then don't tap any keys. The use case for this is when a user wants to use MonitorControl for a monitor that resides in one location (e.g. their home), but does not want to use MonitorControl in another location (e.g. their workplace). But they also don't want to manually run or quit MonitorControl when they move locations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 07:03:50 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/MonitorControl#1067
No description provided.