mirror of
https://github.com/MonitorControl/MonitorControl.git
synced 2026-05-15 14:15:55 -06:00
[PR #183] [CLOSED] If there isn't at least one enabled DDC external display, then don't tap any keys #1067
Labels
No labels
Status: Abandoned
arm64
beta
beta
bug
done
duplicate
enhancement
feedback needed from reporter
in progress
invalid
investigating
known Issue
monitor Issue
pull-request
translation
unable to reproduce
unreleased
x86
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/MonitorControl#1067
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/MonitorControl/MonitorControl/pull/183
Author: @opbarnes
Created: 3/4/2020
Status: ❌ Closed
Base:
master← Head:master📝 Commits (3)
0612a09If there isn't at least one enabled DDC external display, then don't tap any keys. The use case for this is when a user wants to use MonitorControl for a monitor that resides in one location (e.g. their home), but does not want to use MonitorControl in another location (e.g. their workplace). But they also don't want to manually run or quit MonitorControl when they move locations.b948865Removed errant semicolone63473dFixed a bug where checking if there is a need for a media key tap on CGDisplayRegisterReconfigurationCallback (there would be a need if one of the displays after the display reconfiguration is a enabled DDC external display)📊 Changes
2 files changed (+28 additions, -7 deletions)
View changed files
📝
MonitorControl/AppDelegate.swift(+27 -7)📝
MonitorControl/UI/Cells/ButtonCellView.swift(+1 -0)📄 Description
If there isn't at least one enabled DDC external display, then don't tap any keys. The use case for this is when a user wants to use MonitorControl for a monitor that resides in one location (e.g. their home), but does not want to use MonitorControl in another location (e.g. their workplace). But they also don't want to manually run or quit MonitorControl when they move locations.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.