[PR #152] [CLOSED] Fix flickering OSD and refactor logic for volume slider. #1062

New issue

Closed

opened 2026-05-05 07:03:40 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:03:40 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/152
Author: @reitermarkus
Created: 11/22/2019
Status: ❌ Closed

Base: master ← Head: osd

📝 Commits (3)

faf39d0 Fix flickering OSD and refactor logic for volume slider.
8d2aeff Update DDC.swift dependency.
a1e633a Don't save volume when muting.

📊 Changes

5 files changed (+72 additions, -67 deletions)

View changed files

📝 Cartfile.resolved (+1 -1)
📝 MonitorControl/Display.swift (+50 -51)
📝 MonitorControl/Info.plist (+1 -1)
📝 MonitorControl/UI/SliderHandler.swift (+19 -13)
📝 MonitorControlHelper/Info.plist (+1 -1)

📄 Description

This fixes the flickering/hiding of the display's OSD by readding errorRecoveryWaitTime: self.hideOsd ? 0 : nil which was removed.

Also, the volume slider now behaves the same way as the native macOS volume slider: It will only change the volume after a mouse-up event and it will also play the volume-changed sound.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/152 **Author:** [@reitermarkus](https://github.com/reitermarkus) **Created:** 11/22/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `osd` --- ### 📝 Commits (3) - [`faf39d0`](https://github.com/MonitorControl/MonitorControl/commit/faf39d0b59e68508fd43c1c71af46567b34bdb46) Fix flickering OSD and refactor logic for volume slider. - [`8d2aeff`](https://github.com/MonitorControl/MonitorControl/commit/8d2aeff54331d236cdc4b8ede128dd99a8a69b58) Update `DDC.swift` dependency. - [`a1e633a`](https://github.com/MonitorControl/MonitorControl/commit/a1e633a7d612dd51b034da8fa9540b1766a03948) Don't save volume when muting. ### 📊 Changes **5 files changed** (+72 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `Cartfile.resolved` (+1 -1) 📝 `MonitorControl/Display.swift` (+50 -51) 📝 `MonitorControl/Info.plist` (+1 -1) 📝 `MonitorControl/UI/SliderHandler.swift` (+19 -13) 📝 `MonitorControlHelper/Info.plist` (+1 -1) </details> ### 📄 Description This fixes the flickering/hiding of the display's OSD by readding `errorRecoveryWaitTime: self.hideOsd ? 0 : nil` which was removed. Also, the volume slider now behaves the same way as the native macOS volume slider: It will only change the volume after a mouse-up event and it will also play the volume-changed sound. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>