[PR #116] [MERGED] Fix mute on monitors that don’t support it (#107) #1051

New issue

Closed

opened 2026-05-05 07:03:20 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:03:20 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/116
Author: @robertbressi
Created: 8/25/2019
Status: ✅ Merged
Merged: 9/30/2019
Merged by: @JoniVR

Base: master ← Head: user/rbressi/107-mismatching-mute-levels

📝 Commits (1)

a296b5d Fix mute on monitors that don’t support it (#107)

📊 Changes

4 files changed (+193 additions, -91 deletions)

View changed files

📝 MonitorControl/AppDelegate.swift (+7 -15)
📝 MonitorControl/Display.swift (+142 -55)
📝 MonitorControl/Support/Utils.swift (+39 -21)
📝 MonitorControl/UI/SliderHandler.swift (+5 -0)

📄 Description

FIXED: Issue where trying to use the “true” mute command on unsupported monitors would cause the mute/unmute key to do nothing
FIXED: Issue where “0” chiclets would be shown when the step value was less than the value of one filled chiclet but greater than 0

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/116 **Author:** [@robertbressi](https://github.com/robertbressi) **Created:** 8/25/2019 **Status:** ✅ Merged **Merged:** 9/30/2019 **Merged by:** [@JoniVR](https://github.com/JoniVR) **Base:** `master` ← **Head:** `user/rbressi/107-mismatching-mute-levels` --- ### 📝 Commits (1) - [`a296b5d`](https://github.com/MonitorControl/MonitorControl/commit/a296b5d068579c2cdc1dc4dea275502eee3f63c1) Fix mute on monitors that don’t support it (#107) ### 📊 Changes **4 files changed** (+193 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl/AppDelegate.swift` (+7 -15) 📝 `MonitorControl/Display.swift` (+142 -55) 📝 `MonitorControl/Support/Utils.swift` (+39 -21) 📝 `MonitorControl/UI/SliderHandler.swift` (+5 -0) </details> ### 📄 Description - FIXED: Issue where trying to use the “true” mute command on unsupported monitors would cause the mute/unmute key to do nothing - FIXED: Issue where “0” chiclets would be shown when the step value was less than the value of one filled chiclet but greater than 0 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>