[PR #97] [MERGED] implement AdvancedPrefsViewController with custom polling #1045

New issue

Closed

opened 2026-05-05 07:03:08 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:03:08 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/97
Author: @JoniVR
Created: 5/18/2019
Status: ✅ Merged
Merged: 8/28/2019
Merged by: @JoniVR

Base: master ← Head: advanced-settings

📝 Commits (10+)

2962ffa implement AdvancedPrefsViewController with custom polling
89a6c6a add multiple displays
5708929 refactor
0399ee8 add resetAllPrefs button to AdvancedPrefsController
63a9a55 Merge branch 'master'
11fabb1 fixes after merge
90fba58 increase build number to fix build (heh)
2d9d5de cleanup
78a8933 add missing value isEnabled when loading displays
00738c1 make sure slider values are being changed on main thread

📊 Changes

23 files changed (+888 additions, -102 deletions)

View changed files

📝 .swiftlint.yml (+2 -0)
📝 Cartfile.resolved (+2 -2)
📝 MonitorControl.xcodeproj/project.pbxproj (+69 -21)
📝 MonitorControl/AppDelegate.swift (+35 -21)
📝 MonitorControl/Display.swift (+66 -2)
➕ MonitorControl/Extensions/Display+Extension.swift (+7 -0)
➖ MonitorControl/Extensions/Display+Whitelist.swift (+0 -29)
📝 MonitorControl/Extensions/NSNotification+Extension.swift (+5 -0)
➕ MonitorControl/Manager/DisplayManager.swift (+35 -0)
➕ MonitorControl/Support/OnlyIntegerValueFormatter.swift (+15 -0)
➕ MonitorControl/Support/PollingMode.swift (+24 -0)
📝 MonitorControl/Support/Utils.swift (+19 -1)
📝 MonitorControl/UI/Base.lproj/Main.storyboard (+334 -0)
📝 MonitorControl/UI/Cells/ButtonCellView.swift (+0 -0)
📝 MonitorControl/UI/Cells/FriendlyNameCellView.swift (+0 -1)
➕ MonitorControl/UI/Cells/HideOsdCellView.swift (+25 -0)
➕ MonitorControl/UI/Cells/LongerDelayCellView.swift (+41 -0)
➕ MonitorControl/UI/Cells/PollingCountCellView.swift (+24 -0)
➕ MonitorControl/UI/Cells/PollingModeCellView.swift (+31 -0)
➕ MonitorControl/View Controllers/AdvancedPrefsViewController.swift (+132 -0)

...and 3 more files

📄 Description

partly implements changes discussed in #37.

This is what the menu currently looks like:

I'm thinking we'd probably want monitor specific polling settings though?
I'd like some input on how that should look, should we use another NSPopupMenu with the friendlyName?

TODO:

Translations? (can be done through new PR's)
Make it work for each display specific (this is a bit hard to test for me since I only have one display, and I wanted to hear the feedback first)
Add longerDelay option
Add hideOsd option

Please feel free to add/make changes or point out things that still need changing, this is very much a work in progress.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/97 **Author:** [@JoniVR](https://github.com/JoniVR) **Created:** 5/18/2019 **Status:** ✅ Merged **Merged:** 8/28/2019 **Merged by:** [@JoniVR](https://github.com/JoniVR) **Base:** `master` ← **Head:** `advanced-settings` --- ### 📝 Commits (10+) - [`2962ffa`](https://github.com/MonitorControl/MonitorControl/commit/2962ffa1833cdac884ac3238f8104998af28a65e) implement AdvancedPrefsViewController with custom polling - [`89a6c6a`](https://github.com/MonitorControl/MonitorControl/commit/89a6c6a08140e3b41450b4b62ef2a22c6615ee1f) add multiple displays - [`5708929`](https://github.com/MonitorControl/MonitorControl/commit/570892929732d06dc5945ca7aa1d6af1d3851fe6) refactor - [`0399ee8`](https://github.com/MonitorControl/MonitorControl/commit/0399ee8e59ea70ec27f7bd44e29fe1fe158ed25c) add `resetAllPrefs` button to `AdvancedPrefsController` - [`63a9a55`](https://github.com/MonitorControl/MonitorControl/commit/63a9a557bf405053b05f8b37b8899b97f93f175c) Merge branch 'master' - [`11fabb1`](https://github.com/MonitorControl/MonitorControl/commit/11fabb120edc8ca60f7eb4655d7b3930f45695e0) fixes after merge - [`90fba58`](https://github.com/MonitorControl/MonitorControl/commit/90fba58ef8552bdb619460f193263fb7b9c98aad) increase build number to fix build (heh) - [`2d9d5de`](https://github.com/MonitorControl/MonitorControl/commit/2d9d5de22d810646cfa3dedd67fe1882c8a10daa) cleanup - [`78a8933`](https://github.com/MonitorControl/MonitorControl/commit/78a8933de9daa2864f78a8692721314d24c93bff) add missing value `isEnabled` when loading displays - [`00738c1`](https://github.com/MonitorControl/MonitorControl/commit/00738c17794a0224d1d3d435ce5e269607b8b640) make sure slider values are being changed on main thread ### 📊 Changes **23 files changed** (+888 additions, -102 deletions) <details> <summary>View changed files</summary> 📝 `.swiftlint.yml` (+2 -0) 📝 `Cartfile.resolved` (+2 -2) 📝 `MonitorControl.xcodeproj/project.pbxproj` (+69 -21) 📝 `MonitorControl/AppDelegate.swift` (+35 -21) 📝 `MonitorControl/Display.swift` (+66 -2) ➕ `MonitorControl/Extensions/Display+Extension.swift` (+7 -0) ➖ `MonitorControl/Extensions/Display+Whitelist.swift` (+0 -29) 📝 `MonitorControl/Extensions/NSNotification+Extension.swift` (+5 -0) ➕ `MonitorControl/Manager/DisplayManager.swift` (+35 -0) ➕ `MonitorControl/Support/OnlyIntegerValueFormatter.swift` (+15 -0) ➕ `MonitorControl/Support/PollingMode.swift` (+24 -0) 📝 `MonitorControl/Support/Utils.swift` (+19 -1) 📝 `MonitorControl/UI/Base.lproj/Main.storyboard` (+334 -0) 📝 `MonitorControl/UI/Cells/ButtonCellView.swift` (+0 -0) 📝 `MonitorControl/UI/Cells/FriendlyNameCellView.swift` (+0 -1) ➕ `MonitorControl/UI/Cells/HideOsdCellView.swift` (+25 -0) ➕ `MonitorControl/UI/Cells/LongerDelayCellView.swift` (+41 -0) ➕ `MonitorControl/UI/Cells/PollingCountCellView.swift` (+24 -0) ➕ `MonitorControl/UI/Cells/PollingModeCellView.swift` (+31 -0) ➕ `MonitorControl/View Controllers/AdvancedPrefsViewController.swift` (+132 -0) _...and 3 more files_ </details> ### 📄 Description partly implements changes discussed in #37. This is what the menu currently looks like: ![ezgif com-video-to-gif](https://user-images.githubusercontent.com/7591717/57969543-65a72500-7978-11e9-993d-52d637b65ca5.gif) I'm thinking we'd probably want monitor specific polling settings though? I'd like some input on how that should look, should we use another `NSPopupMenu` with the `friendlyName`? ### TODO: - [ ] Translations? (can be done through new PR's) - [x] Make it work for each display specific (this is a bit hard to test for me since I only have one display, and I wanted to hear the feedback first) - [x] Add `longerDelay` option - [x] Add `hideOsd` option Please feel free to add/make changes or point out things that still need changing, this is very much a work in progress. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>