[PR #96] [MERGED] Changed mute command from '0 speaker volume' to 'true' mute (0x8D) #1044

New issue

Closed

opened 2026-05-05 07:03:01 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:03:01 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/96
Author: @robertbressi
Created: 5/18/2019
Status: ✅ Merged
Merged: 5/18/2019
Merged by: @the0neyouseek

Base: master ← Head: true-mute-command

📝 Commits (2)

707385d Changed mute command from '0 speaker volume' to 'true' mute (0x8D)
0bf00f5 swiftformat changes

📊 Changes

3 files changed (+25 additions, -11 deletions)

View changed files

📝 MonitorControl/Display.swift (+23 -9)
📝 MonitorControl/Info.plist (+1 -1)
📝 MonitorControlHelper/Info.plist (+1 -1)

📄 Description

On my particular monitor (Samsung C34J79X), when the speaker volume is set to "0" and the MonitorControl OSD shows the audio as muted, the sound is not actually muted, it's just really soft.

Checking out the available DDC commands, there was one (0x8D - .audioMuteScreenBlank) that seemed to actually do the trick nicely.

I've implemented this such that the transitions between volume > 0, mute and unmute should be covered - from my testing on two monitors (mine and an LG 27UD58-B), they seem to work correctly.

I'm not 100% sure whether all monitors are able to handle the 0x8D command, so it'd be great if there could be some more testing on this.

Also, I'm not well-versed in Swift, so any suggestions to improve the quality of the change would be most welcome!

Lastly, this is an amazing and completely necessary piece of software, so thanks to all the contributors and maintainers!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/96 **Author:** [@robertbressi](https://github.com/robertbressi) **Created:** 5/18/2019 **Status:** ✅ Merged **Merged:** 5/18/2019 **Merged by:** [@the0neyouseek](https://github.com/the0neyouseek) **Base:** `master` ← **Head:** `true-mute-command` --- ### 📝 Commits (2) - [`707385d`](https://github.com/MonitorControl/MonitorControl/commit/707385d16ef989ced1fe893ea4511d267af34428) Changed mute command from '0 speaker volume' to 'true' mute (0x8D) - [`0bf00f5`](https://github.com/MonitorControl/MonitorControl/commit/0bf00f5072276b19a3388f50bf5bc04929db3fd7) swiftformat changes ### 📊 Changes **3 files changed** (+25 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl/Display.swift` (+23 -9) 📝 `MonitorControl/Info.plist` (+1 -1) 📝 `MonitorControlHelper/Info.plist` (+1 -1) </details> ### 📄 Description On my particular monitor (Samsung C34J79X), when the speaker volume is set to "0" and the MonitorControl OSD shows the audio as muted, the sound is not actually muted, it's just really soft. Checking out the available DDC commands, there was one (0x8D - .audioMuteScreenBlank) that seemed to actually do the trick nicely. I've implemented this such that the transitions between volume > 0, mute and unmute should be covered - from my testing on two monitors (mine and an LG 27UD58-B), they seem to work correctly. I'm not 100% sure whether all monitors are able to handle the 0x8D command, so it'd be great if there could be some more testing on this. Also, I'm not well-versed in Swift, so any suggestions to improve the quality of the change would be most welcome! Lastly, this is an amazing and completely necessary piece of software, so thanks to all the contributors and maintainers! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>