[PR #77] [MERGED] 🔧 Improved Accessibility Permissions handling #1031

New issue

Closed

opened 2026-05-05 07:02:42 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:02:42 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/77
Author: @JoniVR
Created: 5/8/2019
Status: ✅ Merged
Merged: 5/23/2019
Merged by: @the0neyouseek

Base: master ← Head: quitafterperms

📝 Commits (6)

91adfac quits app after asking for accessibility permissions
233f749 Update Localizable.strings
d14058a Merge branch 'master' into quitafterperms
5aaea31 Merge branch 'master' into quitafterperms
9f19178 add accessibilty observer
8c099b8 Small fixes

📊 Changes

5 files changed (+22 additions, -2 deletions)

View changed files

📝 MonitorControl.xcodeproj/project.pbxproj (+5 -0)
📝 MonitorControl/AppDelegate.swift (+10 -0)
➕ MonitorControl/Extensions/NSNotification+Extension.swift (+5 -0)
📝 MonitorControl/Info.plist (+1 -1)
📝 MonitorControlHelper/Info.plist (+1 -1)

📄 Description

Small Quality of Life change.

Currently when the app shows the popup asking for accessibility permissions, the app doesn't work right after granting these permissions because the app is still launched with previous permissions (would be my guess).

This just makes sure the app exits after asking for permissions and tells the user to restart manually after setting permissions. I think it's a bit more user friendly, as the app doesn't work without a manual restart after granting permissions, but let me know what you think.

~~I looked into somehow listening for this setting but I don't think it's possible.~~

~~Also, you might want to proofread those French and German translations, since I used DeepL for translations~~

edit:
Permissions now work once the user grants them without having to manually restart the app.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/77 **Author:** [@JoniVR](https://github.com/JoniVR) **Created:** 5/8/2019 **Status:** ✅ Merged **Merged:** 5/23/2019 **Merged by:** [@the0neyouseek](https://github.com/the0neyouseek) **Base:** `master` ← **Head:** `quitafterperms` --- ### 📝 Commits (6) - [`91adfac`](https://github.com/MonitorControl/MonitorControl/commit/91adfaca2d07302c92c9575292888e3f8dd363a0) quits app after asking for accessibility permissions - [`233f749`](https://github.com/MonitorControl/MonitorControl/commit/233f749af3184b4e1dc14829a153d5ce6f1241d5) Update Localizable.strings - [`d14058a`](https://github.com/MonitorControl/MonitorControl/commit/d14058ae446b482fb8d38e43d745827baeae94cb) Merge branch 'master' into quitafterperms - [`5aaea31`](https://github.com/MonitorControl/MonitorControl/commit/5aaea31a627685063cb92d3d79e3317d21842623) Merge branch 'master' into quitafterperms - [`9f19178`](https://github.com/MonitorControl/MonitorControl/commit/9f19178e5b42dd59e8baab697b393305537a0c34) add accessibilty observer - [`8c099b8`](https://github.com/MonitorControl/MonitorControl/commit/8c099b8b44c5cb2c2ac9675df5a2e4108cb48f02) Small fixes ### 📊 Changes **5 files changed** (+22 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl.xcodeproj/project.pbxproj` (+5 -0) 📝 `MonitorControl/AppDelegate.swift` (+10 -0) ➕ `MonitorControl/Extensions/NSNotification+Extension.swift` (+5 -0) 📝 `MonitorControl/Info.plist` (+1 -1) 📝 `MonitorControlHelper/Info.plist` (+1 -1) </details> ### 📄 Description Small Quality of Life change. ~Currently when the app shows the popup asking for accessibility permissions, the app doesn't work right after granting these permissions because the app is still launched with previous permissions (would be my guess).~ ~This just makes sure the app exits after asking for permissions and tells the user to restart manually after setting permissions. I think it's a bit more user friendly, as the app doesn't work without a manual restart after granting permissions, but let me know what you think.~ ~I looked into somehow listening for this setting but I don't think it's possible.~ ~Also, you might want to proofread those French and German translations, since I used [DeepL](https://www.deepl.com) for translations~ edit: Permissions now work once the user grants them without having to manually restart the app. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>