[PR #21] [MERGED] Fix function keys not working and retry more often when getting values. #1021

New issue

Closed

opened 2026-05-05 07:02:23 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 07:02:23 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/MonitorControl/MonitorControl/pull/21
Author: @reitermarkus
Created: 3/26/2018
Status: ✅ Merged
Merged: 3/26/2018
Merged by: @the0neyouseek

Base: master ← Head: fix-function-keys-and-retry-values

📝 Commits (5)

d96c11a Update ddcctl submodule.
d630f3d Update dependencies.
4dbd060 Enable displays by default.
cbf85ba Retry more often to get values from display.
c396388 Only print when debugging.

📊 Changes

9 files changed (+77 additions, -25 deletions)

View changed files

📝 MonitorControl/AppDelegate.swift (+5 -10)
📝 MonitorControl/Objects/ButtonCellView.swift (+3 -0)
📝 MonitorControl/Prefs/DisplayPrefsViewController.swift (+4 -4)
📝 MonitorControl/Prefs/KeysPrefsViewController.swift (+4 -0)
📝 MonitorControl/Prefs/MainPrefsViewController.swift (+10 -0)
📝 MonitorControl/Utils.swift (+47 -6)
📝 Podfile (+0 -1)
📝 Podfile.lock (+3 -3)
📝 ddcctl (+1 -1)

📄 Description

This fixes function keys not working because displays aren't enabled by default, but only after unchecking and re-checking them in preferences.

Also I added a loop which tries more often to get the values from the display, since for me the default value of 10 tries in ddcctl does not work reliably. For me, the average is at about 200 tries, and can be up to 600 tries. And since this is only done once at launch, there shouldn't be any overhead afterwards.

Fixes https://github.com/the0neyouseek/MonitorControl/issues/13.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/MonitorControl/MonitorControl/pull/21 **Author:** [@reitermarkus](https://github.com/reitermarkus) **Created:** 3/26/2018 **Status:** ✅ Merged **Merged:** 3/26/2018 **Merged by:** [@the0neyouseek](https://github.com/the0neyouseek) **Base:** `master` ← **Head:** `fix-function-keys-and-retry-values` --- ### 📝 Commits (5) - [`d96c11a`](https://github.com/MonitorControl/MonitorControl/commit/d96c11a9d814862756d4a96357e72e690238e98a) Update `ddcctl` submodule. - [`d630f3d`](https://github.com/MonitorControl/MonitorControl/commit/d630f3d695758954dbbe639c32ac7707a2c7b611) Update dependencies. - [`4dbd060`](https://github.com/MonitorControl/MonitorControl/commit/4dbd06093d147315166c0f8ad98a053382611a2b) Enable displays by default. - [`cbf85ba`](https://github.com/MonitorControl/MonitorControl/commit/cbf85ba9427a58da9cdd85d86f98e42183e0fece) Retry more often to get values from display. - [`c396388`](https://github.com/MonitorControl/MonitorControl/commit/c3963884725a327fd78bd4c8f2b3732f3ef16571) Only print when debugging. ### 📊 Changes **9 files changed** (+77 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `MonitorControl/AppDelegate.swift` (+5 -10) 📝 `MonitorControl/Objects/ButtonCellView.swift` (+3 -0) 📝 `MonitorControl/Prefs/DisplayPrefsViewController.swift` (+4 -4) 📝 `MonitorControl/Prefs/KeysPrefsViewController.swift` (+4 -0) 📝 `MonitorControl/Prefs/MainPrefsViewController.swift` (+10 -0) 📝 `MonitorControl/Utils.swift` (+47 -6) 📝 `Podfile` (+0 -1) 📝 `Podfile.lock` (+3 -3) 📝 `ddcctl` (+1 -1) </details> ### 📄 Description This fixes function keys not working because displays aren't enabled by default, but only after unchecking and re-checking them in preferences. Also I added a loop which tries more often to get the values from the display, since for me the default value of 10 tries in `ddcctl` does not work reliably. For me, the average is at about 200 tries, and can be up to 600 tries. And since this is only done once at launch, there shouldn't be any overhead afterwards. Fixes https://github.com/the0neyouseek/MonitorControl/issues/13. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>