From f0d09f5346583ed6c5ddc54b560a99e8d35f3148 Mon Sep 17 00:00:00 2001
From: waydabber <37590873+waydabber@users.noreply.github.com>
Date: Fri, 27 Aug 2021 21:15:21 +0200
Subject: [PATCH] Fix 'Disable Volume OSD' being not disabled on Software Only
 displays (#542)

---
 MonitorControl/Info.plist                                       | 2 +-
 .../View Controllers/DisplaysPrefsViewController.swift          | 2 +-
 MonitorControlHelper/Info.plist                                 | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/MonitorControl/Info.plist b/MonitorControl/Info.plist
index 13a3607..d55c75f 100644
--- a/MonitorControl/Info.plist
+++ b/MonitorControl/Info.plist
@@ -19,7 +19,7 @@
 	<key>CFBundleShortVersionString</key>
 	<string>$(MARKETING_VERSION)</string>
 	<key>CFBundleVersion</key>
-	<string>2884</string>
+	<string>2886</string>
 	<key>LSApplicationCategoryType</key>
 	<string>public.app-category.utilities</string>
 	<key>LSMinimumSystemVersion</key>
diff --git a/MonitorControl/View Controllers/DisplaysPrefsViewController.swift b/MonitorControl/View Controllers/DisplaysPrefsViewController.swift
index 3a54b54..b227581 100644
--- a/MonitorControl/View Controllers/DisplaysPrefsViewController.swift	
+++ b/MonitorControl/View Controllers/DisplaysPrefsViewController.swift	
@@ -131,7 +131,7 @@ class DisplaysPrefsViewController: NSViewController, PreferencePane, NSTableView
         cell.displayImage.image = NSImage(named: NSImage.computerName)!
       }
       // Disable Volume OSD
-      if let externalDisplay = display as? ExternalDisplay, !externalDisplay.isVirtual {
+      if let externalDisplay = display as? ExternalDisplay, !externalDisplay.isVirtual, !externalDisplay.isSw() {
         cell.disableVolumeOSDButton.state = externalDisplay.hideOsd ? .on : .off
         cell.disableVolumeOSDButton.isEnabled = true
       } else {
diff --git a/MonitorControlHelper/Info.plist b/MonitorControlHelper/Info.plist
index b20b67c..6f37b89 100644
--- a/MonitorControlHelper/Info.plist
+++ b/MonitorControlHelper/Info.plist
@@ -19,7 +19,7 @@
 	<key>CFBundleShortVersionString</key>
 	<string>$(MARKETING_VERSION)</string>
 	<key>CFBundleVersion</key>
-	<string>2884</string>
+	<string>2886</string>
 	<key>LSApplicationCategoryType</key>
 	<string>public.app-category.utilities</string>
 	<key>LSBackgroundOnly</key>